feat: searchable review branch selector#878
Open
loftiskg wants to merge 4 commits intocan1357:mainfrom
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebefff680c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
loftiskg
force-pushed
the
loftiskg/feat-review-branch-selector
branch
from
8c7c6d7 to
686a2ea
Compare
Contributor
|
Nice, looking forward to this one 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a searchable branch picker to
/reviewwhen choosing a PR-style base branch, replacing the plain string selector for large branch lists. This matters because repositories with many remote branches currently make base-branch selection slow and noisy; the new UI keeps the same review flow while making branch narrowing interactive.Sequencing
Standalone PR.
Reviewer notes
HookUIContext["custom"]signature change: it now documents and types thekeybindingsargument that custom components already receive, so theReviewCommandcallback matches the actual API.Changes
SearchableStringSelectorComponentfor inline fuzzy filtering over string option lists./reviewPR-style base branch selection fromctx.ui.select(...)toctx.ui.custom(...)with the new searchable selector.HookUIContext["custom"]typing/docs to include thekeybindingsparameter passed into custom component factories./reviewintegration.packages/coding-agent/CHANGELOG.md.Test plan
bun test test/review-branch-selector.test.ts